feat(metal): precompiled internal shaders #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidbus
reviewed
Dec 15, 2025
| # Shader compilation functions for Plume | ||
| # Using DXC for HLSL to SPIR-V compilation and Metal for macOS | ||
|
|
||
| # Build file_to_c tool (shared with plume core) |
Contributor
There was a problem hiding this comment.
Any reason not to just unify this whole shader compilation utility with the new one? May be useful for consumers.
Contributor
Author
There was a problem hiding this comment.
Didn't want to make this PR too big, this one just aims to precompile and embed the shaders Metal uses -- but yes, I think I'll right after make a follow up PR that provides some primitives for shader compilation
dcvz
commented
Dec 15, 2025
|
|
||
| if(APPLE AND NOT CMAKE_OSX_DEPLOYMENT_TARGET) | ||
| # 10.15 because of our use of supportsFamily() | ||
| set(CMAKE_OSX_DEPLOYMENT_TARGET "10.15" CACHE STRING "Minimum macOS deployment target") |
Contributor
Author
There was a problem hiding this comment.
realized we'd never set one, best to set one
| # Shader compilation functions for Plume | ||
| # Using DXC for HLSL to SPIR-V compilation and Metal for macOS | ||
|
|
||
| # Build file_to_c tool (shared with plume core) |
Contributor
Author
There was a problem hiding this comment.
Didn't want to make this PR too big, this one just aims to precompile and embed the shaders Metal uses -- but yes, I think I'll right after make a follow up PR that provides some primitives for shader compilation
squidbus
approved these changes
Dec 15, 2025
dcvz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add cmake step that precompiles the internal shaders Metal backend uses